Untertitel in Aufnahmen völlig asynchron

[dvboxer]

subtitles have little to do with driver
It runs over tuxtext.
The only thing needed for syncgronisation is video pts.
video pts comes from the dvb api.

I was merely quoting the comment in the OpenPLi source code. And I am puzzled as to why this problem seems to be box specific. Buggy drivers would explain that. Anyway, could you check in the suggested change?

[dvboxer]

Of course these are all chinese to me, as I don't have the knowledge to interprete those code lines, but I very much appreciate your efforts in this issue.

The difference in the code is that in our case the timing is meddled with regardless of whether the subtitle is early or late. Let's say it is 25 seconds early. Then the code calculates "current time" - "time when it is to be displayed" and this is -25. Because of the "abs" (absolute value) this is changed to +25. Then (the ">SUBT_TXT_ABNORMAL_PTS_DIFF" part) this is bigger than the allowed 20 seconds so the timing is changed. In OpenPLi the "abs" is missing so "-25>20" is checked and that is false so the timing is left as it is.

I hope someone from OATV team will listen to these.

Yes please!!

[dvboxer]

This is the commit in OpenPLi that dealt with the problem:

Fix subtitle runahead on recordings

Some receivers have a bug in the file drivers that deliver subtitles on playback of records completely out of sync with the video, making them unusable. This PR slightly adjusts the bad timing handler to treat subtitles that have been delivered too early by the filesystem as valid and to queue them up for showing later at the appropriate time. The handling of subtitles that arrive too late remains unchanged.

[listener]

dass das Problem der fehlenden Synchronisierung immer zu Beginn der Wiedergabe auftritt oder erst nach einer gewissen Zeit?
Ich vermute bei mir ein api getpts Problem das nur bei hd / fullhd genau nach 70 Minuten die pts durchdrehen

that no sync problem is there always from the start of playback or does it first come after a certain time ?
I suspect with me an api getpts problem that only with hd / fullhd exactly after 70 minutes the pts goes wild

[GH_162]

that no sync problem is there always from the start of playback or does it first come after a certain time ?

For me (SF8008 - OATV 7.4.2) they start ok, but after a few lines (in less than a minute) they either come too late/early or disappear at all.
To reiterate, this is only for subtitles of .ts recordings - subtitles of downloaded media play fine, including embedded .mkv subs.

[dvboxer]

dass das Problem der fehlenden Synchronisierung immer zu Beginn der Wiedergabe auftritt oder erst nach einer gewissen Zeit?
Ich vermute bei mir ein api getpts Problem das nur bei hd / fullhd genau nach 70 Minuten die pts durchdrehen

that no sync problem is there always from the start of playback or does it first come after a certain time ?
I suspect with me an api getpts problem that only with hd / fullhd exactly after 70 minutes the pts goes wild

It is the same here like GH_162 said. The first few seconds are okay after that the subtitles go astray. It is obviously the same bug that was corrected almost five years ago in OpenPLi. See the commit I linked in my last post. That does exactly what I suggested, namely to leave alone the timing for subtitles that were sent too early. And GH_162 confirmed that the bug is gone in OpenPLi. So again, would anyone please apply that patch!

[dvboxer]

Da sich nichts tut, habe ich heute versucht, das Image selbst zu backen. Das ist mir tatsächlich gelungen, hat mehrere Stunden gedauert, aber im Prinzip geht es. Nun wollte ich lokal den Patch selbst einbauen, allerdings gibt es auf der Festplatte den Quellcode in der Form gar nicht. Eine Suche nach der Datei mit

Code: Alles auswählen

find /home/openatvbuilder/openatv7.4 -name servicedvb.cpp

ist erfolglos. Ich vermute mal, dass das openatv enigma2 git nur temporär ausgepackt, dann übersetzt und danach wieder gelöscht wird. Es sind in dem Verzeichnis fast 65000 Unterverzeichnisse. So ist das wohl hoffnungslos. Deshalb noch einmal die Bitte:

Kann jemand in folgendem Code in Funktion

Code: Alles auswählen

eDVBServicePlay::newDVBSubtitlePage

(ab Zeile 3717 der Datei https://github.com/openatv/enigma2/blob ... .cpp#L3724):

Code: Alles auswählen

if ( abs(pos-p.m_show_time)>SUBT_TXT_ABNORMAL_PTS_DIFFS && (m_is_pvr || m_timeshift_enabled))
{
    // Subtitles delivered over 20 seconds too late
    eDebug("[eDVBServicePlay] Video pts:%lld, subtitle show_time:%lld, diff:%.02fs BAD TIMING", pos, p.m_show_time, (p.m_show_time - pos) / 90000.0f);
    eDVBSubtitlePage tmppage;
    tmppage = p;
    tmppage.m_show_time = pos + eSubtitleSettings::subtitle_noPTSrecordingdelay;
    m_dvb_subtitle_pages.push_back(tmppage);
}…

das

Code: Alles auswählen

abs(...)

um

Code: Alles auswählen

pos-p.m_show_time

entfernen. Es ergibt keinen Sinn! Im Kommentar darunter steht, Untertitel mehr als 20 Sekunden zu spät geliefert. Durch den Absolutwert wird dieser Code aber auch ausgeführt, wenn die Untertitel 20 Sekunden zu früh kommen. Das zerstört das Timing auf einigen Boxen, die bei der Wiedergabe wegen kaputter Dateitreiber die Untertitel asynchron zum Video liefern. In OpenPLi ist dieser Bug vor fünf Jahren gefixt worden!

[GH_162]

Although nothing seems to be happening about it, I'd like to add another issue that I have just noticed about recordings' subtitles in OpenATV.
When resuming the playback of a .ts recording, OpenPLi remembers which subtitle was selected and continues that way, while OpenATV completely forgets about subs and the desired subtitle has to be selected again.

[dvboxer]

Although nothing seems to be happening about it, I'd like to add another issue that I have just noticed about recordings' subtitles in OpenATV.
When resuming the playback of a .ts recording, OpenPLi remembers which subtitle was selected and continues that way, while OpenATV completely forgets about subs and the desired subtitle has to be selected again.

I can't confirm that. openATV has always remembered if and which subtitles I had been chosen previously in both recordings and live TV. I think there is a setting for this. Yes, in 6.4 under "automatic language selection" (might be different in 7.4) I have "Remember used subtitles of a program" or so (translating on the fly from my german GUI).

[dvboxer]

Ich habe soeben einen pull request in github mit dem erwähnten openPLi-fix erstellt und hoffe, dass er gemerged wird. [For GH_162: I just fixed the bug (based on the OpenPli patch) in my fork of the openATV enigma2 git and sent a pull request hoping it will be merged into the master]

[GH_162]

openATV has always remembered if and which subtitles I had been chosen previously in both recordings and live TV.

For live TV yes, but for recordings subs I think I'll have to look further in settings, although I'm sure I've specified it in auto-language section.

[For GH_162: I just fixed the bug (based on the OpenPli patch) in my fork of the openATV enigma2 git and sent a pull request hoping it will be merged into the master]

That's great news, thanks again. Hopefully it will be merged soon and this issue will be over.

[Jogibär]

Schau mal da...

Oder da...


Funktioniert bei mir mit .ts oder mkv zuverlässig auch nach beenden des filmes in der mitte z.b. und wieder abspielen.